Add a message listener when generateSW is called with skipWaiting: false #1929
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @philipwalton
Fixes #1753
If
generateSW
is called from our build tools, andskipWaiting
isfalse
(the default), the resulting service worker will include amessage
event listener which checks forevent.data.type === 'SKIP_WAITING'
. If the service worker receives that message, it will callself.skipWaiting()
.We should update our recipes to include an example of this once it gets deployed.