-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display an overlay for syntax errors #89
Comments
I agree we should print the terminal output in an overlay if the compilation fails. @glenjamin worked on https://github.com/glenjamin/webpack-hot-middleware that does this, but IIRC it had some other problems. So I’d like to see this as a feature, but probably implemented as a custom client instead of the one that ships with WebpackDevServer. |
I'd happily accept any PRs / specific fixes for problems in hot-middleware, it already has a custom HMR client and is widely used. You are of course free to port/fork, but it'd be good to share if possible. |
Could you make it not depend on polyfill in IE? As I recall this was the biggest issue. |
(Not saying it’s the only one tho. If you could make a PR porting from WDS to the middleware it would be easier to find other issues.) |
One thing I love about Brunch is that in case of error it will show a system notification, no config required. |
Sounds interesting. Perhaps we should do that. Want to take a stab at PR? |
There even seems to be a webpack plugin for that already https://www.npmjs.com/package/webpack-error-notification |
Which doesn't work on Windows, though. Sure, I'll take a stab at it tomorrow! |
The options for this are either plain WebSocket, which is IE10+ or a lib that magically deals with fallbacks - which would be weightier. Any thoughts on what is preferable?
|
What was the motivation behind not using WebSockets? |
Ironically I thought it'd be simpler & more reliable!
|
Uses webpack-notifier under the hood. No setup necessary. Supports Notification Center on OS X, Toaster on Windows 8 and later. Falls back to Growl if present. Ref facebook#89.
(Submitted #131 to add notifications) |
I have a proof of concept of this working: https://twitter.com/dan_abramov/status/773799004878565376. |
#419 landed :) |
I was just looking into it. 😄 |
My dev flow is to edit the code, and thanks to hot reload, look at the browser window to see the effect. I love those dev tools that in dev mode show the equivalent of what create-react-app currently dumps on console into the browser, e.g. when there are syntax errors.
The text was updated successfully, but these errors were encountered: