Recovered some integration tests #10091

maxsbelt · 2020-11-18T07:47:45Z

I noticed that all the latest PRs have a red cross (even merged). This PR contains several fixes that recover some of integration tests:

`jest/no-conditional-expect` rule

Fix 4bcf598.

`jest` version inconsistency

Fix fc4c396.

untracked .eslintcache file

Will be fixed by #10177.

missing `React` in tests after eject

Fix 7b8c760.

src regex issue

Introduced by #9516.
The encoded version of the optimized image ends with k=.

Fix fe5fbee.

facebook-github-bot · 2020-11-18T07:47:51Z

Hi @maxsbelt!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot · 2020-11-18T11:29:39Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

packages/react-scripts/config/jest/babelTransform.js

raix · 2020-12-04T20:54:39Z

@ianschmitz @iansu any reason not to prioritize merging this pull-request?

We currently have to fix the test suite locally and run locally to make sure we are not breaking tests further - with the growth of pending pull-requests this one will at least make work easier as we can rely on CI to run tests again?

Not sure if we should just comment out the failing tests eg. PnP in environment tests are simply broken etc. and setup a policy for only merging if tests are green?

raix · 2020-12-04T21:19:21Z

packages/cra-template-typescript/template/gitignore

@@ -17,6 +17,7 @@
 .env.development.local
 .env.test.local
 .env.production.local
+.eslintcache


I guess this would be fixed by #10177 (but this pr should not be blocked by it - honestly better to get it merged)

Updated in 4bf2990. Now some of the recovered tests will be temporarily broken but I think it's ok.

ianschmitz · 2020-12-08T04:46:45Z

Thank you so much @maxsbelt. Much appreciated! ❤️

celerytea · 2020-12-08T05:25:37Z

Hey thanks for this but you may need to remove the babelrc and configFile setting from the babelTransform.js file though, like in here

create-react-app/packages/react-scripts/config/webpack.config.js

Lines 411 to 420 in 8f2413e

    
               require.resolve('babel-preset-react-app'), 
        
               { 
        
                 runtime: hasJsxRuntime ? 'automatic' : 'classic', 
        
               }, 
        
             ], 
        
           ], 
        
           // @remove-on-eject-begin 
        
           babelrc: false, 
        
           configFile: false, 
        
           // Make sure we have a unique cache identifier, erring on the

maxsbelt · 2020-12-08T06:03:57Z

Hi @celerytea. Since this PR is already merged you can open a new one with suggested changes.

* Fix noFallthroughCasesInSwitch/jsx object is not extensible (facebook#9921) Co-authored-by: Konstantin Simeonov <kon.simeonov@protonmail.com> * Add logo license to README * Remove trailing space in reportWebVitals.ts (facebook#10040) * docs: add React Testing Library as a library requiring jsdom (facebook#10052) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * Increase Workbox's maximumFileSizeToCacheInBytes (facebook#10048) * Create FUNDING.yml * replace inquirer with prompts (facebook#10083) - remove `react-dev-utils/inquirer` public import * Prepare 4.0.1 release * Prepare 4.0.1 release * Publish - cra-template-typescript@1.1.1 - cra-template@1.1.1 - create-react-app@4.0.1 - react-dev-utils@11.0.1 - react-scripts@4.0.1 * chore: bump web-vital dependency version (facebook#10143) * chore: bump typescript version (facebook#10141) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * Add TypeScript 4.x as peerDependency to react-scripts(facebook#9964) * remove chalk from formatWebpackMessages (facebook#10198) * Upgrade @svgr/webpack to fix build error (facebook#10213) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * Improve vendor chunk names in development (facebook#9569) * Update postcss packages (facebook#10003) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * Recovered some integration tests (facebook#10091) * Upgrade sass-loader (facebook#9988) * Move ESLint cache file into node_modules (facebook#9977) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * Revert "Update postcss packages" (facebook#10216) This reverts commit 580ed5d. * Remove references to Node 8 (facebook#10214) * fix(react-scripts): add missing peer dependency react and update react-refresh-webpack-plugin (facebook#9872) * Update using-the-public-folder.md (facebook#10314) Some library --> Some libraries * docs: add missing override options for Jest config (facebook#9473) * Fix CI tests (facebook#10217) * appTsConfig immutability handling by immer (facebook#10027) Co-authored-by: mad-jose <joset@yeswearemad.com> * Add support for new BUILD_PATH advanced configuration variable (facebook#8986) * Add opt-out for eslint-webpack-plugin (facebook#10170) * Prepare 4.0.2 release * Publish - cra-template-typescript@1.1.2 - cra-template@1.1.2 - create-react-app@4.0.2 - react-dev-utils@11.0.2 - react-error-overlay@6.0.9 - react-scripts@4.0.2 * tests: update test case to match the description (facebook#10384) * Bump webpack-dev-server 3.11.0 -> 3.11.1 (facebook#10312) Resolves facebook#10084 security vulnerability in websocket-driver library version 0.5.6, imported transitively by sockjs * Upgrade eslint-webpack-plugin to fix opt-out flag (facebook#10590) * update immer to 8.0.1 to address vulnerability (facebook#10412) Resolves facebook#10411 Bumps immer version to 8.0.1 to address the prototype pollution vulnerability with the current 7.0.9 version. * Prepare 4.0.3 release * Update CHANGELOG * Publish - create-react-app@4.0.3 - react-dev-utils@11.0.3 - react-scripts@4.0.3 Co-authored-by: Ryota Murakami <dojce1048@gmail.com> Co-authored-by: Konstantin Simeonov <kon.simeonov@protonmail.com> Co-authored-by: Ian Sutherland <ian@iansutherland.ca> Co-authored-by: sho90 <aznecosann@gmail.com> Co-authored-by: Anyul Rivas <anyulled@gmail.com> Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> Co-authored-by: Jeffrey Posnick <jeffy@google.com> Co-authored-by: Evan Bacon <baconbrix@gmail.com> Co-authored-by: Sahil Purav <sahil5684@gmail.com> Co-authored-by: Hakjoon Sim <trainto@gmail.com> Co-authored-by: Chris Shepherd <chris@chrisshepherd.me> Co-authored-by: Jason Williams <936006+jasonwilliams@users.noreply.github.com> Co-authored-by: Jabran Rafique⚡️ <jabranr@users.noreply.github.com> Co-authored-by: John Ruble <johnruble@gmail.com> Co-authored-by: Morten N.O. Nørgaard Henriksen <morten.n.o.henriksen@icloud.com> Co-authored-by: Sergey Makarov <serega.s.makar@gmail.com> Co-authored-by: EhsanKhaki <ehsankhfr@gmail.com> Co-authored-by: Kristoffer K <merceyz@users.noreply.github.com> Co-authored-by: Aviv Hadar <Avivhdr@gmail.com> Co-authored-by: Tobias Büschel <13087421+tobiasbueschel@users.noreply.github.com> Co-authored-by: mad-jose <44253495+josezone@users.noreply.github.com> Co-authored-by: mad-jose <joset@yeswearemad.com> Co-authored-by: Andrew Hyndman <ajhyndman@hotmail.com> Co-authored-by: Brody McKee <mrmckeb@users.noreply.github.com> Co-authored-by: James George <jamesgeorge998001@gmail.com> Co-authored-by: Dion Woolley <woolley.dion@gmail.com> Co-authored-by: Walker Clem <51654951+wclem4@users.noreply.github.com>

fix react-error-overlay linting errors

4bcf598

maxsbelt requested review from ianschmitz, iansu, mrmckeb and petetnt as code owners November 18, 2020 07:47

maxsbelt added 2 commits November 18, 2020 11:00

increment jest version for consistency

fc4c396

add .eslintcache to .gitignore

2c48c0d

maxsbelt changed the title ~~fix react-error-overlay linting errors~~ [WIP]fix react-error-overlay linting errors Nov 18, 2020

maxsbelt added 2 commits November 18, 2020 13:37

fix ejected tests

7b8c760

fix image test after optimization

0093387

maxsbelt changed the title ~~[WIP]fix react-error-overlay linting errors~~ Recovered some integration tests Nov 18, 2020

facebook-github-bot added the CLA Signed label Nov 18, 2020

RDIL suggested changes Nov 19, 2020

View reviewed changes

packages/react-scripts/config/jest/babelTransform.js Show resolved Hide resolved

remove copyrights on eject

d110fac

RDIL approved these changes Nov 19, 2020

View reviewed changes

ianschmitz added this to the 4.0.2 milestone Nov 26, 2020

ianschmitz added the tag: internal label Nov 26, 2020

raix mentioned this pull request Dec 4, 2020

Webpack 5 support overview #9994

Closed

25 tasks

raix reviewed Dec 4, 2020

View reviewed changes

remove .eslintcache from gitignore

4bf2990

raix mentioned this pull request Dec 4, 2020

Webpack 5 #7929

Closed

maxsbelt mentioned this pull request Dec 7, 2020

New jsx transform not applied when running tests after ejecting #10184

Closed

ianschmitz merged commit 54ad467 into facebook:master Dec 8, 2020

maxsbelt deleted the fix-ci-problems branch December 8, 2020 06:01

drich7449 mentioned this pull request Feb 23, 2021

[Snyk] Security upgrade react-dev-utils from 9.1.0 to 11.0.3 drich7449/create-react-app#22

Open

hzhz mentioned this pull request Feb 23, 2021

[Snyk] Security upgrade react-dev-utils from 10.2.1 to 11.0.3 hzhz/create-react-app#15

Open

sirinartk mentioned this pull request Feb 23, 2021

[Snyk] Security upgrade react-dev-utils from 9.1.0 to 11.0.3 sirinartk/create-react-app#17

Closed

wombleton pushed a commit to AurorNZ/create-react-app that referenced this pull request Jun 1, 2021

Recovered some integration tests (facebook#10091)

d37d7f5

abhiisheek pushed a commit to abhiisheek/create-react-app that referenced this pull request May 19, 2023

Recovered some integration tests (facebook#10091)

b2289e9

abhiisheek pushed a commit to abhiisheek/create-react-app that referenced this pull request May 24, 2023

Recovered some integration tests (facebook#10091)

18a6df5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Recovered some integration tests #10091

Recovered some integration tests #10091

maxsbelt commented Nov 18, 2020 •

edited

Loading

facebook-github-bot commented Nov 18, 2020

facebook-github-bot commented Nov 18, 2020

raix commented Dec 4, 2020

raix Dec 4, 2020 •

edited

Loading

maxsbelt Dec 4, 2020

ianschmitz commented Dec 8, 2020

celerytea commented Dec 8, 2020 •

edited

Loading

maxsbelt commented Dec 8, 2020

Recovered some integration tests #10091

Recovered some integration tests #10091

Conversation

maxsbelt commented Nov 18, 2020 • edited Loading

jest/no-conditional-expect rule

jest version inconsistency

untracked .eslintcache file

missing React in tests after eject

src regex issue

facebook-github-bot commented Nov 18, 2020

facebook-github-bot commented Nov 18, 2020

raix commented Dec 4, 2020

raix Dec 4, 2020 • edited Loading

Choose a reason for hiding this comment

maxsbelt Dec 4, 2020

Choose a reason for hiding this comment

ianschmitz commented Dec 8, 2020

celerytea commented Dec 8, 2020 • edited Loading

maxsbelt commented Dec 8, 2020

maxsbelt commented Nov 18, 2020 •

edited

Loading

`jest/no-conditional-expect` rule

`jest` version inconsistency

missing `React` in tests after eject

raix Dec 4, 2020 •

edited

Loading

celerytea commented Dec 8, 2020 •

edited

Loading