split code blocks in Adding TypeScript page of Create React App documentation for easier copying and pasting #10553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamirmahal
requested review from
ianschmitz,
iansu and
mrmckeb
as code owners
|
@ianschmitz @iansu @mrmckeb What changes would you like to see on this pull request before merging it? |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
|
@ianschmitz @iansu @mrmckeb When can we merge this pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change just updates the "Adding TypeScript" page of the Create React App documentation so that the commands to add TypeScript to either a new or existing Create React App project are in their own, separate code blocks.
This makes them easier to copy and paste, as opposed to copying an entire block of two commands with a commented
# orin them. Hope this helps!Update: I created an ticket that tracks the issue this pull request seeks to fix. This pull request closes #10562 if we decide to merge it.