PoC: supoort absolute path for launchEditor #10563
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To supoort react devtools launch editor feature facebook/react#20821
Current issues
When we develop a react project in
DEV
, we can get the component source file path bysource
, (but it's abosulte path usually, react-dev-utils not support currently.)for example
/Users/username/code/src/app.tsx
🙅♂️/src/app.tsx
👌support custom launchEditorEndpoint
Do we need change these hard code for
launchEditorEndpoint
???So we can inject custom
LaunchEditorEndpoint
by node process env.Test Plan
Please tell me how to test this change ? necessary unit test will be added later when I figure out how to test it.
append
Welcome any suggestion. 😄 This is a
draft
pull request, not the final pull request.