Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error importing createProxyMiddleware function #10766

Closed
wants to merge 1 commit into from

Conversation

AMS777
Copy link

@AMS777 AMS777 commented Mar 31, 2021

When the createProxyMiddleware function is imported with curly braces ({}) like this:
const { createProxyMiddleware } = require('http-proxy-middleware');

it causes following error:
createProxyMiddleware is not a function

The createProxyMiddleware function works when imported without curly braces ({}):
const createProxyMiddleware = require('http-proxy-middleware');

When the `createProxyMiddleware` function is imported with curly braces ({}) like this:
` const { createProxyMiddleware } = require('http-proxy-middleware');`

it causes following error:
`createProxyMiddleware is not a function`

The `createProxyMiddleware` function works when imported without curly braces ({}):
`const createProxyMiddleware = require('http-proxy-middleware');`
@facebook-github-bot
Copy link

Hi @AMS777!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ianschmitz
Copy link
Contributor

You may be using an older version of the middleware. The default import syntax used to be the way but has since changed. See their official documentation: https://github.com/chimurai/http-proxy-middleware/releases/tag/v1.0.0

@ianschmitz ianschmitz closed this Mar 31, 2021
@AMS777
Copy link
Author

AMS777 commented Mar 31, 2021

Effectively, the version installed is 0.19.1. But it was installed today, March 2021, one year after that comment, with the documented statement:
npm install --save-dev http-proxy-middleware
https://github.com/chimurai/http-proxy-middleware#install

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants