-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggest sass instead of node-sass package #10779
Suggest sass instead of node-sass package #10779
Conversation
…ss and add note on how to migrate projects from node-sass to sass
…r node_modules imports
Hi @andrewywong! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Thanks @andrewywong! |
node-sass is deprecated and this is the suggested replacement: facebook/create-react-app#10779
In addition to updating the docs to reference
sass
and its latest features, I've also updated the docs to reflect the fact that we don't need the '~' prefix to resolve modules fromnode_modules
anymore.Closes #10045, closes #10771