Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest sass instead of node-sass package #10779

Merged
merged 2 commits into from
Apr 12, 2021
Merged

Suggest sass instead of node-sass package #10779

merged 2 commits into from
Apr 12, 2021

Conversation

andrewywong
Copy link
Contributor

@andrewywong andrewywong commented Apr 5, 2021

In addition to updating the docs to reference sass and its latest features, I've also updated the docs to reflect the fact that we don't need the '~' prefix to resolve modules from node_modules anymore.

Closes #10045, closes #10771

@facebook-github-bot
Copy link

Hi @andrewywong!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ianschmitz ianschmitz added this to the 4.1 milestone Apr 12, 2021
@ianschmitz ianschmitz changed the title Move away from node sass and update related docs Suggest sass instead of node-sass package Apr 12, 2021
@ianschmitz ianschmitz merged commit 71cbe59 into facebook:master Apr 12, 2021
@ianschmitz
Copy link
Contributor

Thanks @andrewywong!

wombleton pushed a commit to AurorNZ/create-react-app that referenced this pull request Jun 1, 2021
sumanthratna pushed a commit to sumanthratna/create-react-app that referenced this pull request Aug 4, 2021
PhilippWendler added a commit to sosy-lab/benchexec that referenced this pull request Sep 28, 2021
node-sass is deprecated and this is the suggested replacement:
facebook/create-react-app#10779
abhiisheek pushed a commit to abhiisheek/create-react-app that referenced this pull request May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants