Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin babel dependencies #10797

Merged
merged 1 commit into from
May 30, 2021
Merged

Unpin babel dependencies #10797

merged 1 commit into from
May 30, 2021

Conversation

mohd-akram
Copy link
Contributor

This prevents unnecessary duplication of dependencies, and matches upstream.

@facebook-github-bot
Copy link

Hi @mohd-akram!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ianschmitz ianschmitz added this to the 4.1 milestone Apr 12, 2021
Copy link
Contributor

@ianschmitz ianschmitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few other package.json files that should be updated to match:

Do you mind updating:

  • packages/babel-plugin-named-asset-import/package.json
  • packages/react-dev-utils/package.json
  • packages/react-error-overlay/package.json
  • packages/react-scripts/package.json

@ianschmitz
Copy link
Contributor

ianschmitz commented Apr 14, 2021

The latest commits seem to have unpinned most packages. Let's keep it scoped to babel packages for now.

@mohd-akram mohd-akram changed the title Use ^ for babel preset dependencies Unpin babel dependencies Apr 14, 2021
@mohd-akram mohd-akram requested a review from ianschmitz April 14, 2021 17:31
@mrmckeb
Copy link
Contributor

mrmckeb commented May 30, 2021

@ianschmitz are you OK to merge this one now? It looks like all changes have been made as requested.

@ianschmitz ianschmitz merged commit 93241a0 into facebook:master May 30, 2021
@mrmckeb
Copy link
Contributor

mrmckeb commented May 31, 2021

Thanks for your efforts @mohd-akram, and for the reviews @ianschmitz and @MichaelDeBoey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants