Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable src/node_modules #1081

Closed
wants to merge 3 commits into from
Closed

Enable src/node_modules #1081

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f3c1cf6
preprocess local node_modules for jest
Nov 21, 2016
08efff7
only ignore root node_modules
Nov 21, 2016
3ed5b12
haste providesModuleNodeModules hack
modernserf Dec 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-scripts/template/gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# See http://help.github.com/ignore-files/ for more about ignoring files.

# dependencies
node_modules
/node_modules

# testing
coverage
Expand Down
4 changes: 4 additions & 0 deletions packages/react-scripts/utils/createJestConfig.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ module.exports = (resolve, rootDir, isEjecting) => {
setupTestFrameworkScriptFile: setupTestsFile,
testPathIgnorePatterns: ['<rootDir>/(build|docs|node_modules)/'],
testEnvironment: 'node',
preprocessorIgnorePatterns: ["<rootDir>/node_modules"],
haste: {
providesModuleNodeModules: [".*"],
},
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's sort of unfortunate that this will end up in config after ejecting.
(@cpojer do we have better options?)

if (rootDir) {
config.rootDir = rootDir;
Expand Down