Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve #1095 - Add flexibility to the start script #1096

Closed
wants to merge 1 commit into from
Closed

Resolve #1095 - Add flexibility to the start script #1096

wants to merge 1 commit into from

Conversation

license2e
Copy link

Signed-off-by: Ilya Shindyapin ilya@shindyapin.com

@license2e
Resolve facebook#1095 - Add flexibility to the start script
8356b67 
Signed-off-by: Ilya Shindyapin <ilya@shindyapin.com>
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@license2e license2e mentioned this pull request Nov 25, 2016
Closed
@gaearon
Copy link
Contributor

gaearon commented Dec 5, 2016

Thanks for the PR!
Would #1148 satisfy your use case?
It seems a bit more generic.

@gaearon gaearon mentioned this pull request Feb 12, 2017
Closed
@gaearon
Copy link
Contributor

gaearon commented Feb 12, 2017

We likely won't support this way specifically, but I'm open to making it work with BROWSER env variable we added. Please chime in in #1533 if you're interested.

@gaearon gaearon closed this Feb 12, 2017
@gaearon
Copy link
Contributor

gaearon commented May 15, 2017

Seems like this will be fixed by #1590.

@license2e
Copy link
Author

Agreed

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@license2e @facebook-github-bot @gaearon