-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve dependency issues in v5 alpha #11294
Conversation
Terser is shipped in webpack 5 not sure this is the way to go? |
It's required by
|
I'll have to check, anyways we should use the terser plug-in already available in webpack 5 https://webpack.js.org/plugins/terser-webpack-plugin/ |
(Adding the terser dependency is webpack 4 style...) |
That said, I've seen a warning from babel when the babel cache is empty, so the config has an issue |
Those docs also specify to declare it as a dependency
|
@merceyz you are right 👍 - I completely missed that detail |
2d3daeb
to
80b8a29
Compare
What's the problem this PR addresses?
The v5 alpha regressed to have dependency issues.
How did you fix it?
terser-webpack-plugin
as a dependency again@babel/runtime
frombabel-preset-react-app