-
-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add peer dependencies for fork-ts-checker-webpack-plugin #11526
base: main
Are you sure you want to change the base?
Conversation
Hi @bbrk24! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Signed-off-by: William Baker <bbrk24@gmail.com>
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
It's actual for me two |
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
This still needs to be merged to get rid of incorrect warnings |
What's needed to move this forward? Seems like a trivial change and CI errors seem unrelated. |
Why is no one merging this? @iansu @mrmckeb you are assigned. Please approve so this can finally be merged. Workaround (adapted from #11982 (comment)):
|
When using create-react-app with yarn 3, every run of
yarn install
produces these warnings:even though
typescript
andwebpack
are already provided elsewhere. By specifying these as peer dependencies of react-dev-utils, the warnings are silenced without changing what dependencies are installed.Example output before the change:
![image](https://user-images.githubusercontent.com/25109429/136663751-c6748c89-548d-46b1-86e2-b6b0e1b25826.png)
![image](https://user-images.githubusercontent.com/25109429/136663790-922b3e55-162c-428e-a052-acdfe5ca7061.png)
And after the change:
To prove this change doesn't affect the dependency tree, here's the output of
![image](https://user-images.githubusercontent.com/25109429/136663879-451b9e58-e18b-401b-a3a4-2cbafdf6ce60.png)
![image](https://user-images.githubusercontent.com/25109429/136664099-f4a67339-7f42-4112-8893-1ade95954669.png)
npm ls typescript
after the change:And
npm ls webpack
: