Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add peer dependencies for fork-ts-checker-webpack-plugin #11526

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bbrk24
Copy link

@bbrk24 bbrk24 commented Oct 9, 2021

When using create-react-app with yarn 3, every run of yarn install produces these warnings:

➤ YN0002: │ react-dev-utils@npm:11.0.4 doesn't provide typescript (p79ddf), requested by fork-ts-checker-webpack-plugin
➤ YN0002: │ react-dev-utils@npm:11.0.4 doesn't provide webpack (p2af19), requested by fork-ts-checker-webpack-plugin
➤ YN0000: │ Some peer dependencies are incorrectly met; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code

even though typescript and webpack are already provided elsewhere. By specifying these as peer dependencies of react-dev-utils, the warnings are silenced without changing what dependencies are installed.

Example output before the change:
image
And after the change:
image

To prove this change doesn't affect the dependency tree, here's the output of npm ls typescript after the change:
image
And npm ls webpack:
image

@bbrk24 bbrk24 requested review from iansu and mrmckeb as code owners October 9, 2021 15:18
@facebook-github-bot
Copy link

Hi @bbrk24!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Signed-off-by: William Baker <bbrk24@gmail.com>
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@beautyfree
Copy link

It's actual for me two

@stale
Copy link

stale bot commented Jan 8, 2022

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Jan 8, 2022
@evelant
Copy link

evelant commented Jan 25, 2022

This still needs to be merged to get rid of incorrect warnings

@stale stale bot removed the stale label Jan 25, 2022
@lesderid
Copy link

lesderid commented Mar 3, 2022

What's needed to move this forward? Seems like a trivial change and CI errors seem unrelated.

@lesderid
Copy link

lesderid commented Mar 3, 2022

Duplicates: #11716 #11914

@T3rm1
Copy link

T3rm1 commented Apr 15, 2022

Why is no one merging this? @iansu @mrmckeb you are assigned. Please approve so this can finally be merged.

Workaround (adapted from #11982 (comment)):

packageExtensions:
  # awaiting fix: https://github.com/facebook/create-react-app/issues/11982
  'eslint-plugin-flowtype@*':
    peerDependenciesMeta:
      '@babel/plugin-syntax-flow':
        optional: true
      '@babel/plugin-transform-react-jsx':
        optional: true
  # awaiting fix: https://github.com/facebook/create-react-app/pull/11526
  'react-dev-utils@*':
    peerDependencies:
      "typescript": ">=2.7"
      "webpack": ">=4"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants