Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm start - process.env.PORT support #117

Closed
wants to merge 2 commits into from
Closed

npm start - process.env.PORT support #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f47abd8
npm start - process.env.PORT support
dolchi21 Jul 23, 2016
e1415b4
npm start - process.env.HOST support
dolchi21 Jul 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion config/webpack.config.dev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
* of patent rights can be found in the PATENTS file in the same directory.
*/

var PORT = process.env.PORT || 3000;
var HOST = process.env.HOST || 'localhost';

var path = require('path');
var autoprefixer = require('autoprefixer');
var webpack = require('webpack');
Expand All @@ -32,7 +35,7 @@ var buildPath = path.join(__dirname, isInNodeModules ? '../../..' : '..', 'build
module.exports = {
devtool: 'eval',
entry: [
require.resolve('webpack-dev-server/client') + '?http://localhost:3000',
require.resolve('webpack-dev-server/client') + '?http://'+HOST+':'+PORT,
require.resolve('webpack/hot/dev-server'),
path.join(srcPath, 'index')
],
Expand Down
10 changes: 6 additions & 4 deletions scripts/start.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
*/

process.env.NODE_ENV = 'development';
var PORT = process.env.PORT || 3000;
var HOST = process.env.HOST || 'localhost';

var path = require('path');
var chalk = require('chalk');
Expand Down Expand Up @@ -77,7 +79,7 @@ compiler.plugin('done', function (stats) {
if (!hasErrors && !hasWarnings) {
console.log(chalk.green('Compiled successfully!'));
console.log();
console.log('The app is running at http://localhost:3000/');
console.log('The app is running at http://'+HOST+':'+PORT+'/');
console.log();
return;
}
Expand Down Expand Up @@ -130,7 +132,7 @@ function openBrowser() {
execSync(
'osascript ' +
path.resolve(__dirname, './openChrome.applescript') +
' http://localhost:3000/'
' http://'+HOST+':'+PORT+'/'
);
return;
} catch (err) {
Expand All @@ -139,15 +141,15 @@ function openBrowser() {
}
// Fallback to opn
// (It will always open new tab)
opn('http://localhost:3000/');
opn('http://'+HOST+':'+PORT+'/');
}

new WebpackDevServer(compiler, {
historyApiFallback: true,
hot: true, // Note: only CSS is currently hot reloaded
publicPath: config.output.publicPath,
quiet: true
}).listen(3000, 'localhost', function (err, result) {
}).listen(PORT, HOST, function (err, result) {
if (err) {
return console.log(err);
}
Expand Down