chore(test): make all tests install with npm ci
#11723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, individual tests were updating `npm` and running `npm install`, which was redundant with the config in the test runner. This also updates all test runners to `npm@8` and fixes the local Docker test runner, which wasn't working previously.
lukekarrys
force-pushed
the
lk/ci-install
branch
from
a14e990
to
afef74f
Compare
raix
approved these changes
Dec 8, 2021
iansu
suggested changes
Dec 8, 2021
iansu
approved these changes
Dec 8, 2021
|
Thanks! |
This was referenced Apr 12, 2022
This was referenced Jul 25, 2022
This was referenced Aug 26, 2022
This was referenced Nov 29, 2022
abhiisheek
pushed a commit
to abhiisheek/create-react-app
that referenced
this pull request
May 24, 2023
This was referenced Sep 27, 2024
This was referenced Oct 2, 2024
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, individual tests were updating
npmand runningnpm install, which was redundant with the config in the test runner.This also updates all test runners to
npm@8and fixes the local Docker test runner, which wasn't working previously.