Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(webpackDevServer): fix deprecation warning #11862

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

fix(webpackDevServer): fix deprecation warning #11862

wants to merge 10 commits into from
+28 −24

Conversation

zhaomengfan
Copy link

@zhaomengfan zhaomengfan commented Dec 31, 2021 •
edited
Loading

update webpack-dev-server + fix deprecation warning (#11860)

@facebook-github-bot
Copy link

Hi @zhaomengfan!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@zhaomengfan zhaomengfan changed the title fix(webpackDevServer): update webpack-dev-server + fix deprecation warning(#11860) fix(webpackDevServer): fix deprecation warning(#11860) Dec 31, 2021
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@zhaomengfan zhaomengfan changed the title fix(webpackDevServer): fix deprecation warning(#11860) fix(webpackDevServer): fix deprecation warning Jan 4, 2022
@cduff cduff mentioned this pull request Jan 5, 2022
Open
@yann-combarnous
Copy link

@raix , could this be added to 5.0.1, by any chance? It would reduce CRA verbosity on startup.

@raix raix added this to the 5.0.1 milestone Jan 9, 2022
@wcedmisten-reify
Copy link

@zhaomengfan Recommend upgrading webpack-dev-server to 4.7.3 to include a recent security patch

@ramdaniAli
Copy link

Will this deprecation be fixed in a future release?

fitrarhm
fitrarhm reviewed Jan 21, 2022
View reviewed changes
Copy link

@fitrarhm fitrarhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It work. The warning it's gone.

tchebb added a commit to tchebb/wayland-explorer that referenced this pull request Jan 25, 2022
@tchebb
Upgrade react-scripts to v5, tailwindcss to v3, and others
b6b185c 
This makes several significant changes to our dependencies:
 - react-scripts (i.e. create-react-app) is now v5 (from v4)
 - tailwindcss is now v3 (from a variant of v2 targeting postcss v7)
 - postcss is now v8 (from v7)
 - autoprefixer is now v10 (from v9)
 - craco is no longer used because react-scripts v5 natively supports
   tailwindcss

The postcss and autoprefixer upgrades required no changes on our end, as
they're used only through tailwindcss.

The craco removal required minor changes to package.json to go back to
invoking react-scripts directly.

The react-scripts upgrade didn't require any changes apart from the
other dependency upgrades. However, it did introduce a couple new
harmless warnings to the build. The first is a pair of
"DeprecationWarning" messages from webpack-dev-server for which a fix
has already been submitted upstream to create-react-app[1]. The second
is three "Failed to parse source map" messages from source-map-loader.
These are due to a bug in plausible-tracker for which I've submitted a
fix[2].

The tailwindcss upgrade was the most invasive and required a number of
changes to our CSS and config. I fully followed the upgrade guide[3]
and tested as much functionality as I could. As far as I can tell, the
site behaves and appears identical to how it did before.

[1] facebook/create-react-app#11862
[2] plausible/plausible-tracker#23
[3] https://tailwindcss.com/docs/upgrade-guide
tchebb added a commit to tchebb/wayland-explorer that referenced this pull request Jan 26, 2022
@tchebb
Upgrade react-scripts to v5, tailwindcss to v3, and others
74dbef9 
This makes several significant changes to our dependencies:
 - react-scripts (i.e. create-react-app) is now v5 (from v4)
 - tailwindcss is now v3 (from a variant of v2 targeting postcss v7)
 - postcss is now v8 (from v7)
 - autoprefixer is now v10 (from v9)
 - craco is no longer used because react-scripts v5 natively supports
   tailwindcss

The postcss and autoprefixer upgrades required no changes on our end, as
they're used only through tailwindcss.

The craco removal required minor changes to package.json to go back to
invoking react-scripts directly.

The react-scripts upgrade didn't require any changes apart from the
other dependency upgrades. However, it did introduce a couple new
harmless warnings to the build. The first is a pair of
"DeprecationWarning" messages from webpack-dev-server for which a fix
has already been submitted upstream to create-react-app[1]. The second
is three "Failed to parse source map" messages from source-map-loader.
These are due to a bug in plausible-tracker for which I've submitted a
fix[2].

The tailwindcss upgrade was the most invasive and required a number of
changes to our CSS and config. I fully followed the upgrade guide[3]
and tested as much functionality as I could. As far as I can tell, the
site behaves and appears identical to how it did before.

[1] facebook/create-react-app#11862
[2] plausible/plausible-tracker#23
[3] https://tailwindcss.com/docs/upgrade-guide
tchebb added a commit to tchebb/wayland-explorer that referenced this pull request Jan 26, 2022
@tchebb
Upgrade react-scripts to v5, tailwindcss to v3, and others
dd28d95 
This makes several significant changes to our dependencies:
 - react-scripts (i.e. create-react-app) is now v5 (from v4)
 - tailwindcss is now v3 (from a variant of v2 targeting postcss v7)
 - postcss is now v8 (from v7)
 - autoprefixer is now v10 (from v9)
 - craco is no longer used because react-scripts v5 natively supports
   tailwindcss

The postcss and autoprefixer upgrades required no changes on our end, as
they're used only through tailwindcss.

The craco removal required minor changes to package.json to go back to
invoking react-scripts directly.

The react-scripts upgrade didn't require any changes apart from the
other dependency upgrades. However, it did introduce a pair of harmless
"DeprecationWarning" messages from webpack-dev-server to the build, for
which a fix has already been submitted upstream to create-react-app[1].

The tailwindcss upgrade was the most invasive and required a number of
changes to our CSS and config. I fully followed the upgrade guide[2]
and tested as much functionality as I could. As far as I can tell, the
site behaves and appears identical to how it did before.

[1] facebook/create-react-app#11862
[2] https://tailwindcss.com/docs/upgrade-guide
vially pushed a commit to vially/wayland-explorer that referenced this pull request Jan 26, 2022
@tchebb @vially
Upgrade react-scripts to v5, tailwindcss to v3, and others
d80c329 
This makes several significant changes to our dependencies:
 - react-scripts (i.e. create-react-app) is now v5 (from v4)
 - tailwindcss is now v3 (from a variant of v2 targeting postcss v7)
 - postcss is now v8 (from v7)
 - autoprefixer is now v10 (from v9)
 - craco is no longer used because react-scripts v5 natively supports
   tailwindcss

The postcss and autoprefixer upgrades required no changes on our end, as
they're used only through tailwindcss.

The craco removal required minor changes to package.json to go back to
invoking react-scripts directly.

The react-scripts upgrade didn't require any changes apart from the
other dependency upgrades. However, it did introduce a pair of harmless
"DeprecationWarning" messages from webpack-dev-server to the build, for
which a fix has already been submitted upstream to create-react-app[1].

The tailwindcss upgrade was the most invasive and required a number of
changes to our CSS and config. I fully followed the upgrade guide[2]
and tested as much functionality as I could. As far as I can tell, the
site behaves and appears identical to how it did before.

[1] facebook/create-react-app#11862
[2] https://tailwindcss.com/docs/upgrade-guide
@kyclai kyclai mentioned this pull request Feb 8, 2022
Merged
@brookjordan
Copy link

Would love to see this implemented to reduce developer confusion.

@iansu iansu modified the milestones: 5.0.1, 5.0.2 Apr 12, 2022
@jongio jongio mentioned this pull request Apr 25, 2022
Closed
@Meligy
Copy link

Meligy commented Apr 26, 2022

Is there a workaround until this PR is merged?

Or else, is there anything that can help with it? I assume external user review / approval will not count.

@snyk-bot snyk-bot mentioned this pull request Sep 29, 2020
Closed
@icey-franken
Copy link

bump

@sbaggott
Copy link

This is actually breaking our app locally. With react-scripts 5.0.1, when we run npm start, despite it just being a warning it stops the dev server with the deprecation warning. Is there any way to fix this while we wait for 5.0.2?

@pat-ryb
Copy link

pat-ryb commented May 23, 2022

It work. The warning it's gone.

It really does the trick.

@dirkesquire
Copy link

dirkesquire commented Jun 16, 2022 •
edited
Loading

At the moment my app won't start up using react-scripts@5.0.1. I see a lot of failing tests in the requested Review? How do we get this reviewed/fixed/merged in?

This was referenced Jul 8, 2022
Merged
Merged
Merged
Merged
@Eng-Fouad Eng-Fouad mentioned this pull request Aug 6, 2022
Open
@Meligy
Copy link

Meligy commented Aug 6, 2022

Is this planned for 5.0.2?

@ithrforu
Copy link

ithrforu commented Nov 9, 2022 •
edited
Loading

bump.
image

@akhileshgoud2504
Copy link

The issue got fixed with the changes in the below link
https://github.com/facebook/create-react-app/pull/11862/files/2dff88610f9ad215349424d1769b88e0a0d2fa1d
Thank you..!

@micktdj
Copy link

micktdj commented Dec 26, 2022

Is this still planned for 5.0.2 patch ?

@MikeMcC399
Copy link

@BalaM314
Copy link

I can't see the failure reason anymore as Azure dropped the run results, does anyone know why the tests are failing?

@MikeMcC399
Copy link

MikeMcC399 commented Apr 28, 2023 •
edited
Loading

@BalaM314

The whole PR is now stale, so either the original submitter @zhaomengfan would need to rebase or somebody else would need to be active. Considering that the last commit to the master branch was in September 2022 it seems that the repository is no longer being actively maintained.

@imnasnainaec imnasnainaec mentioned this pull request May 8, 2023
Open
@Abel13
Copy link

Abel13 commented Jul 20, 2023

how can I use this branch on my code?

nathanwiles
nathanwiles reviewed Nov 19, 2023
View reviewed changes
Copy link

@nathanwiles nathanwiles left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if I'll be able to make it work, but it's worth a shot, my school project recommends using create-react-app

@morremeyer
Copy link

@nathanwiles Your school project's recommendation is outdated. Take a look at e.g. vite. create-react-app is unmaintained.

@misraelson
Copy link

IMO CRA should be maintained. Lots and lots of production apps still use CRA. This isn't breaking my app, but I do see a warning pop up for a split second before the local server runs. It's wild that this PR is still open, how can we merge it in? @zhaomengfan please merge this

@jaypatel22222
Copy link

Hi Guys, Will this be fixed in any new releases?

@MikeMcC399
Copy link

@jaypatel22222

Hi Guys, Will this be fixed in any new releases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanwiles nathanwiles nathanwiles left review comments

@fitrarhm fitrarhm fitrarhm left review comments

@wmaca wmaca wmaca left review comments

@joshkel joshkel joshkel left review comments

@iansu iansu Awaiting requested review from iansu

@mrmckeb mrmckeb Awaiting requested review from mrmckeb

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
5.0.2
Development

Successfully merging this pull request may close these issues.