-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure split chunks in development #11966
base: main
Are you sure you want to change the base?
Conversation
Credit: @GraxMonzo, @JeremyGrieshop, & @raix Reference facebook#11278 (comment)
Hi @bkrausz! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
splitChunks: isEnvDevelopment | ||
? undefined | ||
: { | ||
chunks: 'all', | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe better will be write smth like this?
splitChunks: isEnvProduction && { chunks: 'all' },
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tednaaa In this case, if isEnvProduction
is false
, the splitChunks
key will be set to false
, thereby overwriting the default configuration of the SplitChunksPlugin
.
#11763 seems to have stalled so putting this out with the requested tweak.
Credit: @GraxMonzo, @JeremyGrieshop, & @raix
Reference #11278 (comment)