fix: webpack hanging under certain circumstance, use process.exitCode… #12292
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sometimes i found out
react-scripts buld
hangs under certain circumstances, like:when i changed process.exit(1) to process.exitCode = 1, it can end up with failure:
According to https://nodejs.org/dist/latest-v16.x/docs/api/process.html#processexitcode_1:
I also find that
webpack
andwebpack-cli
also have simlar issues fixed:fix: fix webpack hanging under certain circumstance
Fix webpack hanging under certain circumstance, use process.exitCode instead of process.exit in compilerCallback
misc(refactor): reduce code duplication use process.exitCode instead of process.exit