Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for cjs files in project and in modules #12605

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mcfedr
Copy link

@mcfedr mcfedr commented Jul 22, 2022

I'm having problems using modules that ship files with .cjs extension, these config changes should allow these files to be processed as other js files.

@mcfedr mcfedr requested a review from mrmckeb as a code owner July 22, 2022 10:52
@facebook-github-bot
Copy link

Hi @mcfedr!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@fryorcraken
Copy link

Please review this PR, I faced the same issue when an ESM dependency that contains a .cjs (generated file) (see waku-org/js-waku#895)

@vezwork
Copy link

vezwork commented Sep 7, 2022

This PR is a duplicate of #12021! I believe this would fix #12155. Hoping for this to be reviewed and merged!

@deivamagalhaes
Copy link

I also would love for this one to be reviewed and merged.

@danny-does-stuff
Copy link

Oh please please review this so that the past 3 days of my life were not in vain! 💀

@jcpeden
Copy link

jcpeden commented Feb 28, 2024

Any reason this hasn't gone in yet? I've spent the past day trying to debug this issue and finally landed on this solution to the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants