-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for cjs files in project and in modules #12605
base: main
Are you sure you want to change the base?
Conversation
Hi @mcfedr! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Please review this PR, I faced the same issue when an ESM dependency that contains a |
This is because @chainsafe/libp2p includes one cjs module. Can be avoided if facebook/create-react-app#12605 is merged.
I also would love for this one to be reviewed and merged. |
Oh please please review this so that the past 3 days of my life were not in vain! 💀 |
Any reason this hasn't gone in yet? I've spent the past day trying to debug this issue and finally landed on this solution to the problem. |
I'm having problems using modules that ship files with
.cjs
extension, these config changes should allow these files to be processed as other js files.