Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues #12304 and #11762 – “
react-scripts start
fails when bothHOST
andproxy
are defined”.Steps to verify the issue
proxy
inpackage.json
of a new project (if verifying within the monorepo code, usepackages/react-scripts/package.json
).HOST
environment variable and run thestart
script, e.g:HOST=example.local yarn run start
Invalid options object. Dev Server has been initialized using an options object that does not match the API schema. options.allowedHosts[0] should be a non-empty string.
After applying this patch, the script will run as expected, setting the
allowedHost
property of the Webpack config to the given hostname.Explanation
The function
createDevServerConfig
expects the hostname as string for its second argument, but instead ofHOST
,urls.lanUrlForConfig
is provided and its value isundefined
.It appears, this bug has been in introduced all the way back in 2017.