Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function parseHomepagePath with more logic #1280

Closed
wants to merge 2 commits into from
Closed

Add function parseHomepagePath with more logic #1280

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c11a57
Add function parseHomepagePath with more logic
lucasavila00 Dec 16, 2016
b13c273
Update webpack.config.prod.js
lucasavila00 Dec 16, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/react-scripts/config/webpack.config.prod.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,20 @@ function ensureSlash(path, needsSlash) {
}
}

// If the user sets the homepage field on package.json as a url starting
// with @ it means they want to set the publicPath themselves.
function parseHomepagePath(path) {
var useAbsolutePath = path.startsWith('@');
return useAbsolutePath ? path.substr(1, path.length - 1) : url.parse(homepagePath).pathname
}

// We use "homepage" field to infer "public path" at which the app is served.
// Webpack needs to know it to put the right <script> hrefs into HTML even in
// single-page apps that may serve index.html for nested URLs like /todos/42.
// We can't use a relative path in HTML because we don't want to load something
// like /todos/42/static/js/bundle.7289d.js. We have to know the root.
var homepagePath = require(paths.appPackageJson).homepage;
var homepagePathname = homepagePath ? url.parse(homepagePath).pathname : '/';
var homepagePathname = homepagePath ? parseHomepagePath(homepagePath) : '/';
// Webpack uses `publicPath` to determine where the app is being served from.
// It requires a trailing slash, or the file assets will get an incorrect path.
var publicPath = ensureSlash(homepagePathname, true);
Expand Down