Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SASS compatibility implemented in react-scripts #1509

Closed
wants to merge 1 commit into from

Conversation

vladkampov
Copy link

I have simply implemented SASS compatibility to the react-scripts.
Guess it would be helpful cause so far when developer need to use SASS in his project with this boilerplate he must eject the create react app.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@cr101
Copy link
Contributor

cr101 commented Feb 9, 2017

Thank you for adding this feature which a lot of web developers need especially if you want to customize Bootstrap or Foundation by changing the SASS variables and settings.

@existentialism
Copy link
Contributor

@vladkampov might want to check out this previous issue for some context: #78 (also #115, #351, #412)

@gaearon
Copy link
Contributor

gaearon commented Feb 12, 2017

Thanks for the PR, but we don't plan to support Sass or any other preprocessor out of the box.
You can find the past discussions about this in other issues and PRs.

You can, however, enable Sass in your projects with a little bit of manual setup.
I hope it's not too much of a burden!

Cheers.

@gaearon gaearon closed this Feb 12, 2017
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants