Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display yarn instead of yarnpkg when creating a new app #1747

Merged
merged 3 commits into from
Mar 7, 2017
Merged

Display yarn instead of yarnpkg when creating a new app #1747

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c751df8
Display yarn instead of yarnpkg
lpalmes Mar 7, 2017
050c03f
Refactored displayd commands
lpalmes Mar 7, 2017
eb6045c
Removed testing directory
lpalmes Mar 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/react-scripts/scripts/init.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,10 @@ module.exports = function(appPath, appName, verbose, originalDirectory, template
cdpath = appPath;
}

// Change command to yarn instead of yarnpkg
if (useYarn)
command = 'yarn';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer we create a separate variable, e.g. displayedCommand, and set it conditionally.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaearon by conditionally you mean?

if (useYarn)
  displayedCommand = 'yarn';
else
  displayedCommand = 'npm';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't mind, as a ternary operator.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready, if may i ask, why a separate variable? To avoid mutations of the command variable?


console.log();
console.log('Success! Created ' + appName + ' at ' + appPath);
console.log('Inside that directory, you can run several commands:');
Expand Down