Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when build is failing due to ESLint errors, filter warnings out #2059

Closed
wants to merge 1 commit into from
Closed

when build is failing due to ESLint errors, filter warnings out #2059

wants to merge 1 commit into from

Conversation

milocosmopolitan
Copy link
Contributor

@gaearon I wasn't sure if you wanted to place process.exit(1) when there are warning or not, but if process.env.CI hasn't set it should print warnings. I've tested by enabling root/.eslintignore line4 packages/react-scripts/template and produce some warning.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon
Copy link
Contributor

gaearon commented May 11, 2017

Hey, thanks for the PR!
I'm sorry I didn't review it in time.

I don't think this does what I wanted. I didn't really do a great job of explaining 😞
I sent #2120 instead which should fix the issue, but I appreciate the effort that went into this!

@gaearon gaearon closed this May 11, 2017
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants