Skip to content

Collapse stack frames that are too close to each other #2142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Collapse stack frames that are too close to each other #2142

wants to merge 1 commit into from
+38 −9

Conversation

gaearon
Copy link
Contributor

@gaearon gaearon commented May 13, 2017

This adjusts warning logic to my latest changes in facebook/react#9679 (comment).

@gaearon gaearon changed the title [WIP] Skip extra React stack frames Collapse stack frames that are too close to each other May 14, 2017
@gaearon
Copy link
Contributor Author

gaearon commented May 14, 2017

No, this messes up DOM manipulations 😞

@gaearon gaearon mentioned this pull request May 14, 2017
Merged
@gaearon
Copy link
Contributor Author

gaearon commented May 14, 2017

Let's do #2143 instead for now.

@gaearon gaearon mentioned this pull request May 14, 2017
Closed
@gaearon
Copy link
Contributor Author

gaearon commented May 14, 2017

Let's do it as part of #2100.

@gaearon gaearon closed this May 14, 2017
@Timer Timer modified the milestone: 0.10.0 May 15, 2017
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gaearon @Timer @facebook-github-bot