Add Promise and fetch polyfills #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Closed
|
Looks good to me 👍 |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used promise (maintained by @ForbesLindesay and widely used at Facebook) and fetch (pretty much standard in the community).
These will be included for everyone. In terms of size, it adds about 4kB min+gzip, and I think it’s a fair tradeoff for getting these features as baseline since they’re so commonly used in the React tutorials.
Promise rejection tracking is on in all environments. If it truly causes performance issues, we can disable it in production. However I wouldn’t expect it to: front-end code isn’t usually as Promise-heavy as Node. There’s a difference between using a Promise here and there, and creating thousands of Promises in tight loops or whatever it is that most benchmarks measure.