Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update jest-enzyme section #2392

Merged
merged 1 commit into from
May 29, 2017
Merged

Conversation

luftywiranda13
Copy link
Contributor

@luftywiranda13 luftywiranda13 commented May 28, 2017

since CRA now uses the latest version of Jest under the hood,
jest-enzyme v3.2.0 is now also working perfectly fine

I've made a PR to update their docs too
enzymejs/enzyme-matchers#99

package.json
screen shot 2017-05-28 at 14 51 55

.test.js file
screen shot 2017-05-28 at 14 52 57

screen shot 2017-05-28 at 14 53 59
note: I intentionally make the test failed (string vs number)

since CRA now use the latest version of Jest under the hood,
`jest-enzyme` v3.2.0 is now working perfectly fine
@gaearon gaearon added this to the 1.0.8 milestone May 29, 2017
@gaearon gaearon merged commit 19c5277 into facebook:master May 29, 2017
@gaearon
Copy link
Contributor

gaearon commented May 29, 2017

Thanks.

@luftywiranda13 luftywiranda13 deleted the patch-1 branch May 29, 2017 21:35
zangrafx added a commit to zangrafx/create-react-app that referenced this pull request May 31, 2017
* master:
  Add WebStorm >2017 launchEditor Support (facebook#2414)
  docs: update `jest-enzyme` section (facebook#2392)
  Fix detection of parent directory in ModuleScopePlugin (facebook#2405)
  Added cache clear to e2e scripts (facebook#2400)
  Fix kill command in e2e-kitchensink.sh cleanup (facebook#2397)
  Revert "Catch "No tests found" during CI" (facebook#2390)
  Fix wrong path expansion in end-to-end test (facebook#2388)
  Suggest just "yarn build" (facebook#2385)
  Catch "No tests found" during CI (facebook#2387)
  Publish
  Add changelog for 1.0.7 (facebook#2384)
  Update webpack to 2.6.1 (facebook#2383)
  Consistently set environment variables (facebook#2382)
  Disable comparisons feature in uglify compression in production (facebook#2379)
  Removed the overriding of reduce_vars to false since webpack v2.6.0 included the fixed for Uglify bug (facebook#2351)
@gaearon gaearon mentioned this pull request Jun 28, 2017
romaindso pushed a commit to romaindso/create-react-app that referenced this pull request Jul 10, 2017
since CRA now use the latest version of Jest under the hood,
`jest-enzyme` v3.2.0 is now working perfectly fine
wmonk referenced this pull request in wmonk/create-react-app-typescript Aug 7, 2017
since CRA now use the latest version of Jest under the hood,
`jest-enzyme` v3.2.0 is now working perfectly fine
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants