Set the public path to the asset manifest entries #2544
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
This looks good to me but it's technically a breaking change, so we'll merge it together with other breaking changes later. |
|
Thanks! |
|
Oops I should have merged this into |
This reverts commit bab2c29. I meant to apply it to `next` instead.
)" This reverts commit aaf022c.
* 'master' of https://github.com/facebook/create-react-app: (220 commits) Publish Changelog for 1.1.4 Update detect-port-alt (facebook#4250) Publish Changelog for 1.1.3 Work around Jest environment resolving bug (facebook#4247) Publish Add 1.1.2 changelog (facebook#4242) Add troubleshooting for Github Pages (facebook#4197) `.mjs` should not resolve before .js files (facebook#4085) Publish Revert "Set the public path to the asset manifest entries (facebook#2544)" Add 1.1.1 changelog Unpin and bump fsevents (for 1.x branch) (facebook#4006) Update dotenv-expand to fix bug with environment variables that contain a $. (facebook#4000) Update instructions for continuous delivery with Netlify (facebook#3971) Include `{json,css}` files in prettier command (facebook#3894) Set the public path to the asset manifest entries (facebook#2544) 1.5.1 pin envinfo version to 3.4.2 (facebook#3853) ... # Conflicts: # packages/react-scripts/config/webpack.config.prod.js # packages/react-scripts/package.json
)" This reverts commit bab2c29. I meant to apply it to `next` instead.
)" This reverts commit bab2c29. I meant to apply it to `next` instead.
As mentioned by this comment, if you set the homepage in your
package.jsonthe entries in yourasset-manifest.jsonare still relative. This is a fix for that