turn on ascii_only for issue with emoji and regex #2596
Merged
+3
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #2488
![screen shot 2017-06-23 at 3 01 48 am](https://user-images.githubusercontent.com/9636410/27453355-55d37376-57c0-11e7-9be0-9d247ccdc84b.png)
![screen shot 2017-06-23 at 3 01 08 am](https://user-images.githubusercontent.com/9636410/27453361-5debf8f8-57c0-11e7-88d2-0a87a8bd3238.png)
Verified the changes by cloning https://github.com/crabicode/create-react-app-emoji and manually editing react-scripts/config/webpack.config.prod.js
Before:
After: