Add Brackets to launchEditor.js

[petetnt]

Hello from the https://github.com/adobe/brackets/ team! 👋

Tested on MacOS, should work on WIN too!

[gaearon]

Hmm. I think we'll hold off until this is implemented:

https://trello.com/c/ikTpxs58/1424-ability-to-browse-to-a-specific-line-in-a-file-using-command-line

All other editors we autodetect can do this.

[petetnt]

Hi @gaearon,

not sure why that ticket is in the Icebox (well I do as the Trello has been been quite mismanaged for a long while as many of the current contributors don't have access...) but Brackets does open the file in the correct line/file automatically (just re-confirmed it on my own computer).

[gaearon]

Hmm. Correct line didn't work for me on Windows. Maybe Windows version has different CLI arguments?

[petetnt]

Could duplicate the correct line part on Windows too myself, not quite sure why the MacOS version manages to open the correct part anyway without the mapping here anyway: https://github.com/petetnt/create-react-app/blob/dca50a5c3b83e1be4a9c08c63c0a4ac405e1434a/packages/react-dev-utils/launchEditor.js#L55-L95 🤔 🤔

We do handle the linenumber in the format of fullpath:linenumber as seen here https://github.com/adobe/brackets/blob/master/src/document/DocumentCommandHandlers.js#L417-L440 like many other editors, but for some reason it does not work at all when launching from command line on Windows. I'll get to the bottom of this ASAP 👍

[gaearon]

Thanks for looking! I'll get merged then, but hope this gets fixed.