Downgrade strip-ansi package
#2692
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Can you verify it worked? |
|
Sure! I just followed the instructions to start the app from the "Setting Up a Local Copy" section of
|
* upstream/master: Publish Changelog for 1.0.10 (facebook#2694) Update CHANGELOG.md Upgrade flow (facebook#2693) Added `gluestick` to the alternatives section (facebook#2402) Downgrade `strip-ansi` package to 3.0.1 (facebook#2692) Fix typo (facebook#2683) Fix typo in README link (facebook#2684) Publish Changelog for 1.0.9 (facebook#2682) Fix external CSS imports (facebook#2680) # Conflicts: # packages/react-dev-utils/package.json # packages/react-scripts/package.json
Mirroring the patch for react-dev-utils that causes dev utils to break in IE11. strip-ansi package arrow function is causing this issue. See react-dev-utils patch PR that was accepted to fix this issue: facebook/create-react-app#2692
Mirroring the patch for react-dev-utils that causes dev utils to break in IE11. strip-ansi package arrow function is causing this issue. See react-dev-utils patch PR that was accepted to fix this issue: facebook/create-react-app#2692
This should fix #2691.
strip-ansiv4.0.0 (used byreact-dev-utils) updatesansi-regexto v3.0.0, which exports an arrow function instead of a regular function. Internet Explorer 11 doesn't support arrow functions, so in development the app throws a syntax error and won't load. Downgrading to the previous version ofstrip-ansi(v3.0.1) also downgradesansi-regexand should resolve the issue.