Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't delete error logs when install fails #2705

Merged
merged 5 commits into from
Jan 20, 2018
Merged

Don't delete error logs when install fails #2705

merged 5 commits into from
Jan 20, 2018

Conversation

mg
Copy link
Contributor

@mg mg commented Jun 30, 2017

  1. Create a list of files to keep after a failed install (remnantFiles)
  2. Remove these files from the delete list
  3. Silently remove those files when creating a new app

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@mg mg mentioned this pull request Jun 30, 2017
Closed
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Timer
Copy link
Contributor

Timer commented Aug 2, 2017

Could you please bring this PR up to date? Sorry about that!

@gaearon gaearon changed the base branch from master to next January 16, 2018 19:23
@gaearon gaearon added this to the 2.0.0 milestone Jan 16, 2018
@gaearon
Copy link
Contributor

gaearon commented Jan 20, 2018

Made a few tweaks. This should work.

@gaearon gaearon merged commit 6b67f4c into facebook:next Jan 20, 2018
@gaearon gaearon mentioned this pull request Jan 20, 2018
Merged
akstuhl pushed a commit to akstuhl/create-react-app that referenced this pull request Mar 15, 2018
@mg @akstuhl
Don't delete error logs when install fails (facebook#2705)
62e212c 
* don't delete error logs

* Style nit

* Fix the logic
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed tag: bug fix
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mg @facebook-github-bot @Timer @gaearon