Add “node” to Jest's moduleFileExtensions #2738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jest's default value for this option is ["js", "json", "jsx", "node"]. CRA's current value is ["web.js", "js", "json", "web.jsx", "jsx"], which is missing one of default ones: "node". This change fixes that. This "node" extension is used in packages that use native code.
|
Thanks for the catch. |
|
Thanks for the merge. This is for projects that are using the same setup for the server. I have my backend code in |
romaindso
pushed a commit
to romaindso/create-react-app
that referenced
this pull request
Jul 10, 2017
Jest's default value for this option is ["js", "json", "jsx", "node"]. CRA's current value is ["web.js", "js", "json", "web.jsx", "jsx"], which is missing one of default ones: "node". This change fixes that. This "node" extension is used in packages that use native code.
|
Hi there! This change is out in |
|
Hi. I tested |
JohnNilsson
referenced
this pull request
in JohnNilsson/create-react-app-typescript
Aug 9, 2017
Jest's default value for this option is ["js", "json", "jsx", "node"]. CRA's current value is ["web.js", "js", "json", "web.jsx", "jsx"], which is missing one of default ones: "node". This change fixes that. This "node" extension is used in packages that use native code.
connectdotz
added a commit
to connectdotz/create-react-app-typescript
that referenced
this pull request
Aug 30, 2017
This is the same issue documented in react-script PR #2738 (facebook/create-react-app#2738), which has already been merged.
morgs32
pushed a commit
to BrickworkSoftware/create-react-app
that referenced
this pull request
Sep 1, 2017
Jest's default value for this option is ["js", "json", "jsx", "node"]. CRA's current value is ["web.js", "js", "json", "web.jsx", "jsx"], which is missing one of default ones: "node". This change fixes that. This "node" extension is used in packages that use native code.
JohnNilsson
referenced
this pull request
in JohnNilsson/create-react-app-typescript
Sep 9, 2017
Jest's default value for this option is ["js", "json", "jsx", "node"]. CRA's current value is ["web.js", "js", "json", "web.jsx", "jsx"], which is missing one of default ones: "node". This change fixes that. This "node" extension is used in packages that use native code.
kasperpeulen
pushed a commit
to kasperpeulen/create-react-app
that referenced
this pull request
Sep 24, 2017
Jest's default value for this option is ["js", "json", "jsx", "node"]. CRA's current value is ["web.js", "js", "json", "web.jsx", "jsx"], which is missing one of default ones: "node". This change fixes that. This "node" extension is used in packages that use native code.
swengorschewski
referenced
this pull request
in swengorschewski/cra-typescript-electron
Oct 16, 2017
Jest's default value for this option is ["js", "json", "jsx", "node"]. CRA's current value is ["web.js", "js", "json", "web.jsx", "jsx"], which is missing one of default ones: "node". This change fixes that. This "node" extension is used in packages that use native code.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jest’s default value for its
moduleFileExtensionsoption is["js", "json", "jsx", "node"]. CRA was not using this option before version 1.0.8, so this default list was used.PR #2511 (merged in version 1.0.8) sets this option to
["web.js", "js", "json", "web.jsx", "jsx"]. The PR is about adding.webextensions, but it is also removing.nodebecause it is not included like other default extensions.Why is this a bug?
Packages using native code through
node-gypimport files with.nodeextension. Using those packages fails the tests with aCannot find module …error.This used to work with version 1.0.7.
Reproduction and testing
This repo is a minimal reproduction of this bug. Tests fail there. Changing
react-scriptsto 1.0.7 or manually applying this change tonode_modules/react-scripts/scripts/utils/createJestConfig.jsfixes the problem.