Remove deprecated rule jsx-a11y/href-no-hash for eslint^4.0.0

[filipposarzana]

Remove this rule we can avoid having a lot of warnings during build of CRA to work event with eslint^4.0.0 and eslint-plugin-jsx-a11y^6.0.2

Line 1: Definition for rule 'jsx-a11y/href-no-hash' was not found jsx-a11y/href-no-hash

[gaearon]

Why do you have 6.x of this plugin?

We explicitly install "eslint-plugin-jsx-a11y": "5.1.1". So this seems like a package installation problem on your end.

[filipposarzana]

We have updated eslint-plugin-jsx-a11y^6.0.2 to keep up a11y

they have removed this rule in their next release so i think it's important including it with releases to come

it's the only thing breaking CRA at the moment since my .eslintrc is clean and i have no rules turned of

[gaearon]

What I'm saying is that the version of the plugin used by CRA is different. How did you get 6.x on your machine? Did you install it manually?

[filipposarzana]

Yes, of course I installed it manually to keep my project up to date and to have 100% a11y rating.

What I'm suggesting here is to keep CRA up to date too, simply by removing this rule and be prepared to next upgrade of a11y

[gaearon]

Yes, of course I installed it manually

To be clear this is not currently supported without ejecting. So it's not surprising this caused issues.

Are you sure that just removing it is the right approach? Perhaps there's some other rule that we should enable or make more broad now. In fact I thought we had a PR doing this—did you get a chance to look through existing PRs?

[Timer]

Seems like the rule was replaced by anchor-is-valid which is a more customizable version.

We should probably incorporate it with a decent configuration.

edit: looks as @gaearon has already done this (#2690).

[czebe]

Any news on this?

[Timer]

There's no problem here, and the plugin doesn't need updated.

It will be updated when we release v2.0.0, however.

[react-scripts-dangerous]

Hello! I'm a bot that helps facilitate testing pull requests.

Your pull request (commit 75d380b) has been released on npm for testing purposes.

npm i react-scripts-dangerous@1.0.12-75d380b.0
# or
yarn add react-scripts-dangerous@1.0.12-75d380b.0
# or
create-react-app --scripts-version=react-scripts-dangerous@1.0.12-75d380b.0 folder/

Note that the package has not been reviewed or vetted by the maintainers. Only install it at your own risk!

Thanks for your contribution!

[gaearon]

Closing in favor of #2690.