Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run npm 5.4.0 in CI #3026

Merged
merged 6 commits into from
Sep 7, 2017
Merged

run npm 5.4.0 in CI #3026

merged 6 commits into from
Sep 7, 2017

Conversation

viankakrisna
Copy link
Contributor

in response to #2792 (comment)

@viankakrisna
Copy link
Contributor Author

screen shot 2017-08-30 at 12 30 43 am

image

@Timer
Copy link
Contributor

Timer commented Aug 29, 2017 •
edited
Loading

I restarted it, might be a Travis flake.

I noticed npm cache clear needs to be ran with --force now, is that something we should do?

@Timer
Copy link
Contributor

Timer commented Aug 29, 2017 •
edited
Loading

Nope, it's dead. 🤷‍♀️

I'd be interested in hearing what this AppVeyor failure is about, though.

@viankakrisna
Copy link
Contributor Author

retrying with npm cache clean --force

@viankakrisna
Copy link
Contributor Author

@Timer
ENOENT: no such file or directory, open 'C:\c\projects\create-react-app-a3khu\packages\babel-preset-react-app'
the path seems weird...

@Timer
Copy link
Contributor

Timer commented Aug 29, 2017 •
edited
Loading

I glazed right over that; npm@5 must not like npm install file:/c/projects/create-react-app-a3khu/packages/babel-preset-react-app; is there a newer format?

@viankakrisna
Copy link
Contributor Author

the previous code is using npm link, i'll revert that changes.

@viankakrisna
Copy link
Contributor Author

npm/npm#15900
seems like the new format is link: i'll try that when this fails.

Also, facebook/flow#4733

@gaearon
Copy link
Contributor

gaearon commented Aug 29, 2017

We can also just cp things if npm link is broken.

@viankakrisna
Copy link
Contributor Author

Sorry i've fallen asleep... Seems like npm link works correctly, any caveat relying on it for e2e?

@viankakrisna
Copy link
Contributor Author

soo (maybe) the remaining issue to get green npm 5++ in CI is for flow-bin to get a proper permission.

@Timer
Copy link
Contributor

Timer commented Sep 7, 2017

5.4.1 has resolved executable permissions.

@viankakrisna
Copy link
Contributor Author

updated the code for accuracy :)

@gaearon gaearon merged commit fcb6dc5 into facebook:master Sep 7, 2017
@gaearon
Copy link
Contributor

gaearon commented Sep 7, 2017

Yaaaay!

This was referenced Sep 10, 2017
Closed
Closed
viankakrisna added a commit to viankakrisna/create-react-app that referenced this pull request Sep 11, 2017
@viankakrisna
Revert "run npm 5.4.0 in CI (facebook#3026)"
c8d3ac9 
This reverts commit fcb6dc5.
@tharakawj tharakawj mentioned this pull request Sep 11, 2017
Merged
Timer pushed a commit that referenced this pull request Sep 12, 2017
@viankakrisna @Timer
Revert "run npm 5.4.0 in CI (#3026)" (#3107)
0e064b3 
This reverts commit fcb6dc5.
matart15 pushed a commit to matart15/create-react-app that referenced this pull request Sep 13, 2017
Merge branch 'master' of https://github.com/facebookincubator/create-…
8a152ae 
…react-app

* 'master' of https://github.com/facebookincubator/create-react-app:
  Resolved issue facebook#2971 (facebook#2989)
  Revert "run npm 5.4.0 in CI (facebook#3026)" (facebook#3107)
  Updated react-error-overlay to latest Flow (0.54.0) (facebook#3065)
  Auto-detect running editor on Linux for error overlay (facebook#3077)
  Clean target directory before compiling overlay (facebook#3102)
  Rerun prettier and pin version (facebook#3058)
  Reload the page when an error has occurred (facebook#3098)
  run npm 5.4.0 in CI (facebook#3026)
  Unmapper Windows compatibility (facebook#3079)
  Update eslint-config npm install command (facebook#3072)
  Set travis config to use 'precise' ci environment
  Publish
  Changelog for 1.0.13
  Add missing slash
  Make error overlay filename configurable (facebook#3028)
  provide empty mock for child_process so importing libraries with it works (facebook#3033)
  Rename Overlay to ErrorOvelay (facebook#3051)
  Strip hash from chunk file name (facebook#3049)
  Fix error overlay 'Object.assign' issue in IE by including polyfills before webpack client (facebook#3046)
thongdong7 pushed a commit to thongdong7/create-react-app that referenced this pull request Sep 24, 2017
@viankakrisna @thongdong7
run npm 5.4.0 in CI (facebook#3026)
88b9e2f 
* run npm 5.4.0 in CI

* run npm cache clean with --force in CI

* use link instead of install

* Update e2e-installs.sh

* Update e2e-kitchensink.sh

* Update e2e-simple.sh
thongdong7 pushed a commit to thongdong7/create-react-app that referenced this pull request Sep 24, 2017
@viankakrisna @thongdong7
Revert "run npm 5.4.0 in CI (facebook#3026)" (facebook#3107)
8035b51 
This reverts commit fcb6dc5.
thongdong7 pushed a commit to thongdong7/create-react-app that referenced this pull request Sep 24, 2017
@viankakrisna @thongdong7
run npm 5.4.0 in CI (facebook#3026)
7470ae3 
* run npm 5.4.0 in CI

* run npm cache clean with --force in CI

* use link instead of install

* Update e2e-installs.sh

* Update e2e-kitchensink.sh

* Update e2e-simple.sh
thongdong7 pushed a commit to thongdong7/create-react-app that referenced this pull request Sep 24, 2017
@viankakrisna @thongdong7
Revert "run npm 5.4.0 in CI (facebook#3026)" (facebook#3107)
8decd96 
This reverts commit fcb6dc5.
kasperpeulen pushed a commit to kasperpeulen/create-react-app that referenced this pull request Sep 24, 2017
@viankakrisna @kasperpeulen
run npm 5.4.0 in CI (facebook#3026)
f3defb9 
* run npm 5.4.0 in CI

* run npm cache clean with --force in CI

* use link instead of install

* Update e2e-installs.sh

* Update e2e-kitchensink.sh

* Update e2e-simple.sh
kasperpeulen pushed a commit to kasperpeulen/create-react-app that referenced this pull request Sep 24, 2017
@viankakrisna @kasperpeulen
Revert "run npm 5.4.0 in CI (facebook#3026)" (facebook#3107)
2141dac 
This reverts commit fcb6dc5.
suutari-ai referenced this pull request in andersinno/create-react-app-ai Jan 25, 2018
@suutari-ai
Merge branch 'master' of https://github.com/wmonk/create-react-app-ty…
7227b64 
…pescript

* 'master' of https://github.com/wmonk/create-react-app-typescript: (265 commits)
  fix typo in changelog
  Update README For 2.13.0
  v2.13.0
  Remove tslint-loader from prod build (again)
  Include TypeScript as devDependency in boilerplate output
  Documented how to define custom module formats for the TypeScript compiler so that you can import images and other files (references wmonk#172)
  v2.12.0
  Update README For 2.12.0
  Update typescript to 2.6.2
  v2.11.0
  Update changelog for 2.11.0
  Fixed problem with tsconfig.json baseUrl and paths
  Update createJestConfig.js
  Update changelog for 2.10.0
  v2.10.0
  Readd transformIgnorePatterns
  Update react-dev-utils
  Update package.json dependencies
  Readd Missing raf Package
  Update JestConfig Creation
  Fix
  Fix Missing Variable
  Fix package.json
  Merge pull request wmonk#204 from StefanSchoof/patch-1
  Merge pull request wmonk#201 from StefanSchoof/patch-1
  Merge pull request wmonk#199 from DorianGrey/master
  Merge pull request wmonk#165 from johnnyreilly/master
  Publish
  Add 1.0.17 changelog (#3402)
  Use new WebpackDevServer option (#3401)
  Fix grammar in README (#3394)
  Add link to VS Code troubleshooting guide (#3399)
  Update VS Code debug configuration (#3400)
  Update README.md (#3392)
  Publish
  Reorder publishing instructions
  Changelog for 1.0.16 (#3376)
  Update favicon description (#3374)
  Changelog for 1.0.15 (#3357)
  Replace template literal; fixes #3367 (#3368)
  CLI@1.4.2
  Publish
  Add preflight CWD check for npm (#3355)
  Stop using `npm link` in tests (#3345)
  Fix for add .gitattributes file #3080 (#3122)
  Mention that start_url needs to be "." for client side routing
  start using npm-run-all to build scss and js (#2957)
  Updating the Service Worker opt-out documentation (#3108)
  Remove an useless negation in registerServiceWorker.js (#3150)
  Remove output.path from dev webpack config (#3158)
  Add `.mjs` support (#3239)
  Add documentation for Enzyme 3 integration (#3286)
  Make uglify work in Safari 10.0 - fixes #3280 (#3281)
  Fix favicon sizes value in manifest (#3287)
  Bump dependencies (#3342)
  recommend react-snap; react-snapshot isn't upgraded for React 16 (#3328)
  Update appveyor.cleanup-cache.txt
  Polyfill rAF in test environment (#3340)
  Use React 16 in development
  Use a simpler string replacement for the overlay
  Clarify the npm precompilation advice
  --no-edit
  Update `eslint-plugin-react` (#3146)
  Add jest coverage configuration docs (#3279)
  Update link to Jest Expect docs (#3303)
  Update README.md
  Fix dead link to Jest "expect" docs (#3289)
  v2.8.0
  Use production React version for bundled overlay (#3267)
  Add warning when using `react-error-overlay` in production (#3264)
  Add external links to deployment services (#3265)
  `react-error-overlay` has no dependencies now (#3263)
  Add click-to-open support for build errors (#3100)
  Update style-loader and disable inclusion of its HMR code in builds (#3236)
  Update url-loader to 0.6.2 for mime ReDoS vuln (#3246)
  Make error overlay to run in the context of the iframe (#3142)
  Upgrade to typescript 2.5.3
  Fix Windows compatibility (#3232)
  Fix package management link in README (#3227)
  Watch for changes in `src/**/node_modules` (#3230)
  More spec compliant HTML template (#2914)
  Minor change to highlight dev proxy behaviour (#3075)
  Correct manual proxy documentation (#3185)
  Improve grammar in README (#3211)
  Publish
  Fix license comments
  Changelog for 1.0.14
  BSD+Patents -> MIT (#3189)
  Add link to active CSS modules discussion (#3163)
  Update webpack-dev-server to 2.8.2 (#3157)
  Part of class fields to stage 3 (#2908)
  Update unclear wording in webpack config docs (#3160)
  Display pid in already running message (#3131)
  Link local react-error-overlay package in kitchensink test
  Resolved issue #2971 (#2989)
  Revert "run npm 5.4.0 in CI (#3026)" (#3107)
  Updated react-error-overlay to latest Flow (0.54.0) (#3065)
  Auto-detect running editor on Linux for error overlay (#3077)
  Clean target directory before compiling overlay (#3102)
  Rerun prettier and pin version (#3058)
  ...
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@viankakrisna @Timer @gaearon @facebook-github-bot