Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link local react-error-overlay package in kitchensink test #3139

Merged
merged 1 commit into from
Sep 16, 2017
Merged

Link local react-error-overlay package in kitchensink test #3139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tasks/e2e-kitchensink.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,9 @@ cd "$temp_app_path/test-kitchensink"

# Link to our preset
npm link "$root_path"/packages/babel-preset-react-app
# Link to error overlay package because now it's a dependency
# of react-dev-utils and not react-scripts
npm link "$root_path"/packages/react-error-overlay

# Link to test module
npm link "$temp_module_path/node_modules/test-integrity"
Expand Down Expand Up @@ -220,13 +223,16 @@ E2E_FILE=./build/index.html \

# Unlink our preset
npm unlink "$root_path"/packages/babel-preset-react-app
# Unlink error overlay
npm unlink "$root_path"/packages/react-error-overlay

# Eject...
echo yes | npm run eject

# ...but still link to the local packages
npm link "$root_path"/packages/babel-preset-react-app
npm link "$root_path"/packages/eslint-config-react-app
npm link "$root_path"/packages/react-error-overlay
npm link "$root_path"/packages/react-dev-utils
npm link "$root_path"/packages/react-scripts

Expand Down