Use mock for CSS-files #3590
Use mock for CSS-files #3590
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
**Summary:** Missing CSS files cause failing tests, this is problematic when using a preprocessor such as SASS. **Test plan:** 1. Create a project 2. Delete `src/App.css`. 3. Run `yarn test`. Verify the test passes and does not fail with a `Cannot find module './App.css' from 'App.js'`-error.
|
I prpose this change because I use a CSS-preprocessor with create-react-app, this leads to problems with tests failing on CI. The preprocessor is not run before the tests are executed, therefore the CSS files are missing. Currently I have a A build of a project will still fail, when a CSS file is missing, so this change can not lead to projects that stop working unexpectedly. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Thanks for the PR, but I don't think we'll take this. You could similarly argue a missing file means a mistake that should be caught by tests. As a workaround, you can run the build before tests (it's a good idea anyway). We plan some sort of Sass support in future releases (#2498) so let's focus on that instead. |
Summary:
Missing CSS files cause failing tests, this is problematic when using a
preprocessor such as SASS.
Test plan:
src/App.css.yarn test.Verify the test passes and does not fail with a
Cannot find module './App.css' from 'App.js'-error.