Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #3717

Merged
merged 1 commit into from
Jan 8, 2018
Merged

Update README.md #3717

merged 1 commit into from
Jan 8, 2018

Conversation

maecapozzi
Copy link
Contributor

@maecapozzi maecapozzi commented Jan 8, 2018

  • Update README.md with a note that reminds users to prepend REACT_APP_ to their environment variables.
  • Based on Issue #1977, where Dan Abramov suggests the person who filed the issue create a PR with these changes.
  • I borrowed the language from Adding Custom Environment Variables to avoid adding new or confusing language.

* Update README.md with a note that reminds users to prepend REACT_APP_ to their environment variables. 
* Based on facebook#865, where Dan Abramov suggests the person who filed the issue create a PR with these changes.
* Took the language from [Adding Custom Environment Variables](https://github.com/facebookincubator/create-react-app/tree/master/packages/react-scripts/template#adding-custom-environment-variables)
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon gaearon added this to the 1.0.18 milestone Jan 8, 2018
@gaearon gaearon merged commit 5e2c051 into facebook:master Jan 8, 2018
@maecapozzi maecapozzi deleted the patch-1 branch January 9, 2018 16:27
@gaearon gaearon mentioned this pull request Jan 15, 2018
Pavek pushed a commit to Pavek/create-react-app that referenced this pull request Jul 10, 2018
* Update README.md with a note that reminds users to prepend REACT_APP_ to their environment variables. 
* Based on facebook#865, where Dan Abramov suggests the person who filed the issue create a PR with these changes.
* Took the language from [Adding Custom Environment Variables](https://github.com/facebookincubator/create-react-app/tree/master/packages/react-scripts/template#adding-custom-environment-variables)
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Aug 14, 2018
* Update README.md with a note that reminds users to prepend REACT_APP_ to their environment variables. 
* Based on facebook#865, where Dan Abramov suggests the person who filed the issue create a PR with these changes.
* Took the language from [Adding Custom Environment Variables](https://github.com/facebookincubator/create-react-app/tree/master/packages/react-scripts/template#adding-custom-environment-variables)
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants