Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify JavaScript version for Uglify #3743

Merged
merged 1 commit into from
Jan 11, 2018
Merged

Conversation

Timer
Copy link
Contributor

@Timer Timer commented Jan 11, 2018

Since this now uses uglify-es under the hood, we want to restrict language support to ES5.

This is in line with the current behavior.

Given we've recently merged browserlist support, we should probably set this option based on specific browsers (in a follow up PR).

@Timer Timer added this to the 2.0.0 milestone Jan 11, 2018
@Timer
Copy link
Contributor Author

Timer commented Jan 11, 2018

/cc @viankakrisna for awareness

@Timer Timer merged commit a0fc935 into facebook:master Jan 11, 2018
@Timer Timer deleted the restrict-syntax branch January 11, 2018 03:20
@Timer
Copy link
Contributor Author

Timer commented Jan 11, 2018

Oops, accidentally merged this to master. You can find this in next now.

Timer added a commit that referenced this pull request Jan 11, 2018
Timer added a commit to Timer/create-react-app that referenced this pull request Jan 11, 2018
@viankakrisna
Copy link
Contributor

@Timer niice! filed #3748 for tracking it

Timer added a commit to Timer/create-react-app that referenced this pull request Jan 13, 2018
gaearon pushed a commit that referenced this pull request Jan 13, 2018
Timer added a commit that referenced this pull request Jan 14, 2018
gaearon pushed a commit that referenced this pull request Jan 14, 2018
gaearon pushed a commit that referenced this pull request Jan 14, 2018
gaearon pushed a commit that referenced this pull request Jan 14, 2018
gaearon pushed a commit that referenced this pull request Jan 14, 2018
Timer added a commit to Timer/create-react-app that referenced this pull request Jan 15, 2018
akstuhl pushed a commit to akstuhl/create-react-app that referenced this pull request Mar 15, 2018
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Sep 30, 2018
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants