-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify JavaScript version for Uglify #3743
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/cc @viankakrisna for awareness |
Oops, accidentally merged this to master. You can find this in |
Timer
added a commit
that referenced
this pull request
Jan 11, 2018
Timer
added a commit
to Timer/create-react-app
that referenced
this pull request
Jan 11, 2018
Timer
added a commit
to Timer/create-react-app
that referenced
this pull request
Jan 13, 2018
gaearon
pushed a commit
that referenced
this pull request
Jan 13, 2018
Timer
added a commit
that referenced
this pull request
Jan 14, 2018
gaearon
pushed a commit
that referenced
this pull request
Jan 14, 2018
gaearon
pushed a commit
that referenced
this pull request
Jan 14, 2018
gaearon
pushed a commit
that referenced
this pull request
Jan 14, 2018
gaearon
pushed a commit
that referenced
this pull request
Jan 14, 2018
Timer
added a commit
to Timer/create-react-app
that referenced
this pull request
Jan 15, 2018
akstuhl
pushed a commit
to akstuhl/create-react-app
that referenced
this pull request
Mar 15, 2018
zmitry
pushed a commit
to zmitry/create-react-app
that referenced
this pull request
Sep 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this now uses
uglify-es
under the hood, we want to restrict language support to ES5.This is in line with the current behavior.
Given we've recently merged browserlist support, we should probably set this option based on specific browsers (in a follow up PR).