Use wmic to get process list on Windows #3808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failure seems to be unrelated to this PR. |
|
Yea, sorry, sorting it out |
levrik
force-pushed
the
win-detect-editor-wmic
branch
2 times, most recently
from
06082c5 to
45707e1
Compare
levrik
force-pushed
the
win-detect-editor-wmic
branch
from
45707e1 to
ad81a04
Compare
gaearon
approved these changes
Jan 17, 2018
|
This is great, thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
powershell -Command "Get-Process | Select-Object Path": ~1300ms (current implementation)Get-Process | Select-Object Pathon already running PowerShell daemon/agent: ~300ms (implementation in Speed up editor detection on Windows #2711)wmic process where "executablepath is not null" get executablepath: ~110ms (this implementation)For comparison on other platforms:
ps xon macOS: ~60ms