Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default value for globPatterns #3989

Merged
merged 3 commits into from
Feb 7, 2018
Merged

Commits on Feb 7, 2018

  1. add default value for globPatterns

    without this, the latest alpha broke on start
    ```
    /Users/adeviankakrisnafadlil/Projects/eurecah/node_modules/react-scripts/config/paths.js:130
        .reduce(
         ^
    
    TypeError: Cannot read property 'reduce' of undefined
        at findPkgs (/Users/adeviankakrisnafadlil/Projects/eurecah/node_modules/react-scripts/config/paths.js:130:6)
        at getMonorepoPkgPaths (/Users/adeviankakrisnafadlil/Projects/eurecah/node_modules/react-scripts/config/paths.js:143:22)
        at Object.<anonymous> (/Users/adeviankakrisnafadlil/Projects/eurecah/node_modules/react-scripts/config/paths.js:155:55)
        at Module._compile (module.js:643:30)
        at Object.Module._extensions..js (module.js:654:10)
        at Module.load (module.js:556:32)
        at tryModuleLoad (module.js:499:12)
        at Function.Module._load (module.js:491:3)
        at Module.require (module.js:587:17)
        at require (internal/module.js:11:18)
    error Command failed with exit code 1.
    ```
    viankakrisna committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    d3af56e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6540ec5 View commit details
    Browse the repository at this point in the history
  3. Update paths.js

    Timer committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    32ea84b View commit details
    Browse the repository at this point in the history