-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multipackage monorepo base configuration #405
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
I'll fix that travis explosion |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
@gaearon I'm having a little trouble with the e2e, did I mess something up something obvious I am missing? |
@@ -34,11 +34,11 @@ function resolveApp(relativePath) { | |||
if (isInCreateReactAppSource) { | |||
// create-react-app development: we're in ./config/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to change this comment: we’re in ./packages/react-scripts/config
Try running |
Monorepo basic configuration in reference to #403
Changes made to directory structure
|- packages (new root directory)
|-- create-react-app (was parent directory)
|-- react-scripts (was global-cli)
Testing
To test as you would use
npm i create-react-app -g
cd packages/create-react-app && npm i . -g
to install locally ornpm link
create-react-app my-app
should work as beforeTo test the build process
cd packages/react-scripts && npm i && npm run build
Notes
This is just the directory structure changes, perhaps a little discussion around @hzoo's comment regarding Lerna Independant is warranted?