Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #316 Add React Native Web support #407

Merged
merged 1 commit into from
Aug 9, 2016
Merged

Fix #316 Add React Native Web support #407

merged 1 commit into from
Aug 9, 2016

Conversation

grigio
Copy link
Contributor

@grigio grigio commented Aug 9, 2016

See #316

@ghost ghost added the CLA Signed label Aug 9, 2016
@gaearon
Copy link
Contributor

gaearon commented Aug 9, 2016

Thanks! Have you tested it? Can you show a screenshot of what it's like?

@grigio
Copy link
Contributor Author

grigio commented Aug 9, 2016

@gaearon I've tested that change in my eject(ed) create-react-app in dev and prod mode

@ghost ghost added the CLA Signed label Aug 9, 2016
@gaearon
Copy link
Contributor

gaearon commented Aug 9, 2016

But it doesn't require ejecting, does it? Can you test this in the CRA repo? You can run npm start right in it.

@grigio
Copy link
Contributor Author

grigio commented Aug 9, 2016

Yes without eject now. Tested in my CRA repo fork with npm start

@grigio
Copy link
Contributor Author

grigio commented Aug 9, 2016

schermata 2016-08-09 alle 12 38 02

@gaearon gaearon merged commit 623e1bd into facebook:master Aug 9, 2016
@gaearon
Copy link
Contributor

gaearon commented Aug 9, 2016

Nice, thanks.

@RangerMauve RangerMauve mentioned this pull request Aug 17, 2016
Closed
gaearon pushed a commit that referenced this pull request Aug 22, 2016
@grigio @gaearon
Add React Native Web support (#407)
9e37917
@gaearon gaearon added this to the 0.2.2 milestone Aug 22, 2016
@gaearon gaearon mentioned this pull request Aug 22, 2016
Merged
stayradiated pushed a commit to stayradiated/create-react-app that referenced this pull request Sep 7, 2016
@grigio
Add React Native Web support (facebook#407)
1542970
feiqitian pushed a commit to feiqitian/create-react-app that referenced this pull request Oct 25, 2016
@grigio @feiqitian
Add React Native Web support (facebook#407)
078e011
@tlvince tlvince mentioned this pull request Nov 22, 2016
Closed
@andersryanc andersryanc mentioned this pull request Feb 20, 2018
Closed
@tanneess tanneess mentioned this pull request Feb 21, 2018
Closed
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
0.2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@grigio @gaearon