Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump babel-related deps #4159

Merged
merged 3 commits into from
Mar 18, 2018
Merged

Bump babel-related deps #4159

merged 3 commits into from
Mar 18, 2018

Conversation

existentialism
Copy link
Contributor

Fixes #3891.
Fixes #4154.

"@babel/plugin-transform-destructuring": "7.0.0-beta.41",
"@babel/plugin-transform-react-constant-elements": "7.0.0-beta.41",
"@babel/plugin-transform-react-display-name": "7.0.0-beta.41",
"@babel/plugin-transform-react-jsx": "7.0.0-beta.41",
Copy link

@sowhatdoido sowhatdoido Mar 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, is there a reason you bump @babel/plugin-transform-react-jsx
up to 7.0.0-beta.41 if you remove the plugin from packages/babel-preset-react-app/index.js in d103b41?

Edit: clarification

Copy link
Contributor Author

@existentialism existentialism Mar 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, just oversight. Will fix and update to beta.42 (which will fix the .slice() error and give a better error message) in a sec after we do the release.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - Thanks!! 😄

@Timer
Copy link
Contributor

Timer commented Mar 19, 2018

Thanks @existentialism!

@Timer Timer added this to the 2.0.0 milestone Mar 19, 2018
@gaearon
Copy link
Contributor

gaearon commented Mar 19, 2018

@iansu Please always add a tag and a milestone, that’s how we know to include change in release notes

@iansu
Copy link
Contributor

iansu commented Mar 19, 2018

@gaearon I'll make sure I do that from now on.

rezak-otmani pushed a commit to rezak-otmani/create-react-app that referenced this pull request Mar 19, 2018
tvalentius added a commit to tvalentius/create-react-app that referenced this pull request Mar 20, 2018
kellyrmilligan added a commit to kellyrmilligan/create-react-app that referenced this pull request Mar 22, 2018
* next:
  Fix typos in example monorepo documentation. (facebook#4164)
  Minor fixes to CI (facebook#4193)
  Change no-unused-vars 'args' from none to all to show warning on destructured objects
  Bump babel-related deps (facebook#4159)
  Remove ref to non free resource (facebook#4160)
@existentialism existentialism deleted the bump-babel branch March 27, 2018 04:13
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Sep 30, 2018
* Add explicit dep on plugin-proposal-object-rest-spread to babel-preset-react-app

* Bump babel-related deps to beta.42

* Pass useBuiltIns directly to react-preset
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants