-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump babel-related deps #4159
Bump babel-related deps #4159
Conversation
"@babel/plugin-transform-destructuring": "7.0.0-beta.41", | ||
"@babel/plugin-transform-react-constant-elements": "7.0.0-beta.41", | ||
"@babel/plugin-transform-react-display-name": "7.0.0-beta.41", | ||
"@babel/plugin-transform-react-jsx": "7.0.0-beta.41", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, is there a reason you bump @babel/plugin-transform-react-jsx
up to 7.0.0-beta.41
if you remove the plugin from packages/babel-preset-react-app/index.js in d103b41?
Edit: clarification
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, just oversight. Will fix and update to beta.42 (which will fix the .slice() error and give a better error message) in a sec after we do the release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great - Thanks!! 😄
d103b41
to
394b21b
Compare
Thanks @existentialism! |
@iansu Please always add a tag and a milestone, that’s how we know to include change in release notes |
@gaearon I'll make sure I do that from now on. |
Bump babel-related deps (facebook#4159)
* next: Fix typos in example monorepo documentation. (facebook#4164) Minor fixes to CI (facebook#4193) Change no-unused-vars 'args' from none to all to show warning on destructured objects Bump babel-related deps (facebook#4159) Remove ref to non free resource (facebook#4160)
* Add explicit dep on plugin-proposal-object-rest-spread to babel-preset-react-app * Bump babel-related deps to beta.42 * Pass useBuiltIns directly to react-preset
Fixes #3891.
Fixes #4154.