Update the thread loader test in formatWebpackMessages #4420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iansu
suggested changes
May 8, 2018
| @@ -46,7 +46,7 @@ function formatMessage(message, isError) { | |||
| if (threadLoaderIndex !== -1) { | |||
| return; | |||
| } | |||
| if (line.indexOf('from thread-loader (worker') !== -1) { | |||
| if (/thread.loader/i.test(line)) { | |||
There was a problem hiding this comment.
I think it might be better to replace the . in the regular expression with \s to test for whitespace.
There was a problem hiding this comment.
sure, but what if they put back the dash?
iansu
approved these changes
May 8, 2018
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix done in #3847 is outdated, since thread-loader updated his error message, so now this happens:
I updated the test so now it's more general.