-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix e2e:docker script #4454
Fix e2e:docker script #4454
Conversation
Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired. Before we can review or merge your code, we need you to email cla@fb.com with your details so we can update your status. |
verdaccio.yaml
Outdated
@@ -0,0 +1,49 @@ | |||
# | |||
# This is the default config file. It allows all users to do anything, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move this to tasks
?
Thanks! |
Did CI pass with these changes? |
@iansu both appveyor and travis are green |
Does CI even use this script? I thought it didn't. |
(Travis definitely passed, AppVeyor was failing during yarn fetch which was a common transient issue before so I ignored it) |
I ended up reverting the change in e2e-installs because running it locally was also failing at the same line. But alas I ran it now (after adding back the change) and it just passed. The CIs were indeed using the e2e-*.sh scripts |
Sorry, I got confused by description because I thought it's only relevant to |
Thanks for the info guys. Our tests have been a bit flakey lately so I just wanted to make sure we were in a good state after these changes. |
yarn e2e:docker works locally with this change. Tested before after, before test fails at yarn publish. After yarn publish works as expected.
Checking CI builds.