[internal] Fix node 10 test issue #4626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 17, 2018 00:35
|
Thanks for fixing this. It's been on my todo list. I was looking at submitting a PR to npm-login-cli but it looks like that project isn't very active. This seems like a better solution. |
|
It seems Travis is acting up these days. I've seen quite a bit of random failures on my PRs and other PRs that involves only trivial text changes. |
|
I've noticed this as well. It looks like @Timer might have a potential fix. |
|
Given that this passed on Appveyor I'm happy to merge it. |
iansu
approved these changes
Jun 18, 2018
|
Yeah, we need to get CI working reliably. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace npm-login-cli with npm-auth-to-login, which works with node 10.
Should fix #4383