Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate regenerator from preset-react-app plugins #4630

Merged
merged 1 commit into from
Sep 27, 2018

Conversation

conartist6
Copy link
Contributor

Regenerator is already included by preset-env.

Fixes #4627

@conartist6 conartist6 changed the title Eliminated regenerator from preset-react plugins Eliminate regenerator from preset-react plugins Jun 17, 2018
@conartist6 conartist6 changed the title Eliminate regenerator from preset-react plugins Eliminate regenerator from preset-react-app plugins Jun 17, 2018
@facebook-github-bot
Copy link

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired.

Before we can review or merge your code, we need you to email cla@fb.com with your details so we can update your status.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Regenerator is already included by preset-env.

Fixes facebook#4627
@Timer
Copy link
Contributor

Timer commented Sep 26, 2018

This broke CI so I don't think we can make this change safely.

@Timer Timer closed this Sep 26, 2018
@conartist6
Copy link
Contributor Author

@Timer when you say "this broke CI" could you point me to the failure so that I could attempt to understand what broke and why? It is, unfortunately, also not safe not to make this change, as the bug if fixes is "syntactically correct code can't be compiled".

@gaearon
Copy link
Contributor

gaearon commented Sep 26, 2018

@conartist6 Which bug does this fix? Thanks!

@gaearon
Copy link
Contributor

gaearon commented Sep 26, 2018

Oops sorry, I missed your link. Can you rebase and then we re-run it? We'd need a regression test to understand what you were fixing too.

@gaearon gaearon reopened this Sep 26, 2018
@conartist6
Copy link
Contributor Author

Certainly, I'll write the test and rebase the branch.

@gaearon
Copy link
Contributor

gaearon commented Sep 26, 2018

Seems like it passes now. So maybe it was transient.
In either case we'd need a new integration test for the case that was broken.

@conartist6
Copy link
Contributor Author

That makes sense, CI was broken for every single PR at the time when I first opened this.

@Timer Timer closed this Sep 26, 2018
@conartist6
Copy link
Contributor Author

@Timer Could you please explain?

@Timer Timer reopened this Sep 26, 2018
@Timer
Copy link
Contributor

Timer commented Sep 26, 2018

GitHub doesn't like when you delete a branch that has PRs against it. 😅

@Timer Timer modified the milestones: 2.0.x, 2.0.0-final, 2.0.0 Sep 26, 2018
@Timer Timer changed the base branch from next to master September 27, 2018 04:11
@Timer Timer merged commit 52f2946 into facebook:master Sep 27, 2018
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants