-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate regenerator from preset-react-app plugins #4630
Conversation
Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired. Before we can review or merge your code, we need you to email cla@fb.com with your details so we can update your status. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Regenerator is already included by preset-env. Fixes facebook#4627
This broke CI so I don't think we can make this change safely. |
@Timer when you say "this broke CI" could you point me to the failure so that I could attempt to understand what broke and why? It is, unfortunately, also not safe not to make this change, as the bug if fixes is "syntactically correct code can't be compiled". |
@conartist6 Which bug does this fix? Thanks! |
Oops sorry, I missed your link. Can you rebase and then we re-run it? We'd need a regression test to understand what you were fixing too. |
Certainly, I'll write the test and rebase the branch. |
Seems like it passes now. So maybe it was transient. |
That makes sense, CI was broken for every single PR at the time when I first opened this. |
@Timer Could you please explain? |
GitHub doesn't like when you delete a branch that has PRs against it. 😅 |
Regenerator is already included by preset-env.
Fixes #4627