Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose reportRuntimeError #4709

Merged
merged 2 commits into from
Nov 1, 2018
Merged

Conversation

hipstersmoothie
Copy link
Contributor

Enables calling reportRuntimeError to display a full stack trace.

  • factor out crashWithFrames
  • expose reportRuntimeError

closes #4705

My Usage:

{
	onError: e => reportRuntimeError(e)
}

Result:

screen shot 2018-06-29 at 11 03 14 pm

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@hipstersmoothie
Copy link
Contributor Author

@Timer @bugzpodder

options?: RuntimeReportingOption = {}
) {
currentRuntimeErrorOptions = options;
crashWithFrames(handleRuntimeError)(error);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this exclude the logic present in the other call?

      if (typeof options.onError === 'function') {
        options.onError.call(null);
      }

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could move this code

	try {
      if (typeof options.onError === 'function') {
        options.onError.call(null);
      }
    } finally {
      handleRuntimeError(errorRecord);
    }

into handleRuntimeError?

@hipstersmoothie
Copy link
Contributor Author

@Timer comments addressed

@Timer Timer closed this Sep 26, 2018
@Timer Timer reopened this Sep 26, 2018
@hipstersmoothie
Copy link
Contributor Author

@Timer passing ✅

@Timer Timer added this to the 2.1.1 milestone Oct 31, 2018
@Timer Timer changed the base branch from next to master October 31, 2018 20:30
@Timer Timer merged commit 36ce578 into facebook:master Nov 1, 2018
@hipstersmoothie hipstersmoothie deleted the reportRuntimeError branch November 1, 2018 17:17
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

react-error-overlay expose report runtime error
4 participants