-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use the correct dependency for babel-plugin-dynamic-import-node #4984
use the correct dependency for babel-plugin-dynamic-import-node #4984
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
This was intentional because the package you switched to does not support Babel 7. When it supports Babel 7, we're more than happy to switch back to it! |
Makes sense. |
Would love to see this in the v2.0.0 stable release if possible. Currently, @vikr01 is waiting on some PR's downstream to be reviewed/merged by the airbnb team. |
This isn't going to stop us from releasing 2.0.0 as stable, as we already updated our fork of this plugin to be babel 7 compatible. |
Now that |
Excellent, thanks for letting us know! |
0c1f990
to
6b1cdf3
Compare
6b1cdf3
to
56b4ae5
Compare
Updated the version for |
babel-plugin-transform-dynamic-import
was just a copy ofbabel-plugin-dynamic-import-node
, and it's not been updated for a while whilebabel-plugin-dynamic-import-node
has.