Strip comments from the production build #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
I’m fine with |
|
Lgtm, feel free to merge it when you're done with it |
|
Merging it right now so it doesn't introduce merge conflict hell if someone is working on the same part of the codebase. Feel free to send follow up pull requests |
vjeux
pushed a commit
that referenced
this pull request
Jul 18, 2016
* Strip comments from the production build * Add screw_ie8 options to UglifyJsPlugin
mikechau
referenced
this pull request
in mikechau/create-react-app
Jan 25, 2017
mikechau
referenced
this pull request
in mikechau/create-react-app
Jan 25, 2017
Remove non-text character from tsconfig.json closes #5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do we also want to use Uglify's
screw-ie8option?It will default to
trueas of2.7.0, but Webpack is still on~2.6.0.If so, I can add to this PR - there are 3 different pieces of the uglification process it can be configured for -
compress,mangleandoutput.